From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: bitfield: fix broken Default implementation
Date: Wed, 01 Apr 2026 07:59:01 +1000 [thread overview]
Message-ID: <review-overall-20260331-fix-bitfield-v1-1-ebe1a72b4fae@nvidia.com> (raw)
In-Reply-To: <20260331-fix-bitfield-v1-1-ebe1a72b4fae@nvidia.com>
Overall Series Review
Subject: gpu: nova-core: bitfield: fix broken Default implementation
Author: Eliot Courtney <ecourtney@nvidia.com>
Patches: 5
Reviewed: 2026-04-01T07:59:01.227236
---
This is a single-patch bugfix for a real bug in the `bitfield!` macro's `Default` implementation in the nova-core driver. The bug is clear: the `set_*` methods use a builder pattern (taking `self` by value and returning `Self`), but the `Default` implementation discards the return values, so field defaults are never actually applied. The fix is correct and minimal, and the added kunit test properly validates the fix. **Recommended for merging.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 21:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 7:56 [PATCH] gpu: nova-core: bitfield: fix broken Default implementation Eliot Courtney
2026-03-31 13:21 ` Gary Guo
2026-03-31 13:36 ` Danilo Krummrich
2026-03-31 20:53 ` John Hubbard
2026-03-31 13:47 ` Joel Fernandes
2026-03-31 21:59 ` Claude Code Review Bot [this message]
2026-03-31 21:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260331-fix-bitfield-v1-1-ebe1a72b4fae@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox