From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Minor hmm_test fixes and cleanups
Date: Tue, 31 Mar 2026 16:41:09 +1000 [thread overview]
Message-ID: <review-overall-20260331063445.3551404-1-apopple@nvidia.com> (raw)
In-Reply-To: <20260331063445.3551404-1-apopple@nvidia.com>
Overall Series Review
Subject: Minor hmm_test fixes and cleanups
Author: Alistair Popple <apopple@nvidia.com>
Patches: 4
Reviewed: 2026-03-31T16:41:09.620184
---
This is a well-structured 3-patch series fixing real bugs and warnings in the HMM kernel selftests (`lib/test_hmm.c` and `tools/testing/selftests/mm/hmm-tests.c`). The fixes are appropriate and well-motivated:
1. **Patch 1** fixes a use-after-free crash path reported on arm64 by evicting device pages before freeing the dmirror struct on file close.
2. **Patch 2** fixes portability issues on architectures where PMD size != 2MB (e.g., arm64 with 64K base pages), and cleans up a custom helper in favor of existing utilities.
3. **Patch 3** adds a proper `device.release` method to silence a kernel warning on module unload, and fixes a minor error-handling bug.
The series is generally **good to merge** with a couple of observations below.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-31 6:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 6:34 [PATCH 0/3] Minor hmm_test fixes and cleanups Alistair Popple
2026-03-31 6:34 ` [PATCH 1/3] lib: test_hmm: evict device pages on file close to avoid use-after-free Alistair Popple
2026-03-31 6:41 ` Claude review: " Claude Code Review Bot
2026-03-31 6:34 ` [PATCH 2/3] selftests/mm: hmm-tests: don't hardcode THP size to 2MB Alistair Popple
2026-03-31 6:41 ` Claude review: " Claude Code Review Bot
2026-03-31 6:34 ` [PATCH 3/3] lib: test_hmm: Implement a device release method Alistair Popple
2026-03-31 6:41 ` Claude review: " Claude Code Review Bot
2026-03-31 6:41 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260331063445.3551404-1-apopple@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox