public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: Enable cmu for Tegra186 and Tegra194
Date: Sun, 12 Apr 2026 14:39:02 +1000	[thread overview]
Message-ID: <review-overall-20260406-tegra-drm-cmu-v3-1-dfcb1dda4ad6@gmail.com> (raw)
In-Reply-To: <20260406-tegra-drm-cmu-v3-1-dfcb1dda4ad6@gmail.com>

Overall Series Review

Subject: drm/tegra: Enable cmu for Tegra186 and Tegra194
Author: Aaron Kling via B4 Relay <devnull+webgeek1234.gmail.com@kernel.org>
Patches: 2
Reviewed: 2026-04-12T14:39:02.640673

---

This is a single-patch series (v3) that enables the Color Management Unit (CMU) on Tegra186/Tegra194 nvdisplay hardware, loading an sRGB LUT to correct dark color output. The motivation is sound -- without CMU, colors are noticeably darker than intended, and the vendor bootloader/downstream driver both enable this.

The implementation is straightforward: allocate a DMA-coherent buffer at probe time, populate it with an sRGB correction table, and program the CMU registers during HDMI and DisplayPort enable paths. v3 improvements (dmam_alloc_coherent, removal of improper IOVA null check) are welcome simplifications.

**Key issues:**
- Missing `Signed-off-by` for the `Co-developed-by` tag (process requirement).
- The HDMI and DP paths duplicate the LUT programming sequence -- could be a small helper.
- Minor style nits.

Overall this looks correct and ready with the tagging fix.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-12  4:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06  7:47 [PATCH v3] drm/tegra: Enable cmu for Tegra186 and Tegra194 Aaron Kling via B4 Relay
2026-04-07  4:59 ` Mikko Perttunen
2026-04-12  4:39 ` Claude Code Review Bot [this message]
2026-04-12  4:39 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-07  7:09 [PATCH v4] " Aaron Kling via B4 Relay
2026-04-12  4:04 ` Claude review: " Claude Code Review Bot
2026-04-12  4:04 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260406-tegra-drm-cmu-v3-1-dfcb1dda4ad6@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox