Claude review: Introduce cold reset recovery method

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Introduce cold reset recovery method
Author: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
Patches: 8
Reviewed: 2026-04-12T14:32:33.157016

---

This v3 series adds cold-reset recovery support for the Xe driver, building on top of an unmerged RAS/PCI-error-handling infrastructure series ([PATCH] "Introduce Xe Uncorrectable Error Handling"). The series introduces `DRM_WEDGE_RECOVERY_COLD_RESET` at the DRM core level and wires it up for PUNIT errors in the Xe driver.

**Key concerns:**

1. **Patch 1 is marked "DO NOT REVIEW" but carries significant architectural decisions** that directly affect the reviewability of patches 2-4. The PCI error recovery path in `xe_pci_error_slot_reset()` has serious issues (calling `pdev->driver->remove()`/`probe()` directly, using `devres_release_group()` in a fragile way) that affect the entire series. The dependency chain also means the `xe_sysctrl_mailbox` infrastructure (`has_sysctrl`, `xe_sysctrl_send_command`, etc.) doesn't exist in drm-next, making it impossible to verify compilation or correctness.

2. **The `in_recovery` atomic overlaps with the `wedged.flag` atomic** in unclear ways. Both serve to block operations during error states, but the interaction and lifecycle differences are not well documented.

3. **The cold-reset recovery script in the documentation is incomplete** — it only handles the slot-power-cycle case and does nothing meaningful when no slot is found (just prints "No slot found" and exits).

---

---
Generated by Claude Code Patch Reviewer