public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method
Date: Sun, 12 Apr 2026 14:32:33 +1000	[thread overview]
Message-ID: <review-patch2-20260406142325.157035-8-mallesh.koujalagi@intel.com> (raw)
In-Reply-To: <20260406142325.157035-8-mallesh.koujalagi@intel.com>

Patch Review

```c
+#define DRM_WEDGE_RECOVERY_COLD_RESET	BIT(4)	/* full device cold reset */
```

and:

```c
+	case DRM_WEDGE_RECOVERY_COLD_RESET:
+		return "cold-reset";
```

This is clean and straightforward. One question: the existing recovery methods are ordered from least to most side-effects (NONE < REBIND < BUS_RESET < VENDOR). Where does COLD_RESET fit relative to VENDOR? BIT(4) is after VENDOR (BIT(3)), which implies it's more severe, but the documentation in patch 3 should clarify whether `cold-reset` can be combined with other methods in a bitmask (like REBIND|BUS_RESET is used as the default). A cold-reset is strictly more drastic than a bus-reset, so it should be documented whether userspace should try bus-reset first if both are set.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-12  4:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06 14:23 [PATCH v3 0/4] Introduce cold reset recovery method Mallesh Koujalagi
2026-04-06 14:23 ` [PATCH v3 1/4] Introduce Xe Uncorrectable Error Handling Mallesh Koujalagi
2026-04-12  4:32   ` Claude review: " Claude Code Review Bot
2026-04-06 14:23 ` [PATCH v3 2/4] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method Mallesh Koujalagi
2026-04-08  7:46   ` Raag Jadav
2026-04-12  4:32   ` Claude Code Review Bot [this message]
2026-04-06 14:23 ` [PATCH v3 3/4] drm/doc: Document " Mallesh Koujalagi
2026-04-08  8:01   ` Raag Jadav
2026-04-12  4:32   ` Claude review: " Claude Code Review Bot
2026-04-06 14:23 ` [PATCH v3 4/4] drm/xe: Handle PUNIT errors by requesting cold-reset recovery Mallesh Koujalagi
2026-04-08  8:09   ` Raag Jadav
2026-04-12  4:32   ` Claude review: " Claude Code Review Bot
2026-04-12  4:32 ` Claude review: Introduce cold reset recovery method Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch2-20260406142325.157035-8-mallesh.koujalagi@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox