From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imx/ipuv3: do not adjust hactive for non-8-pixel-aligned modes
Date: Sun, 12 Apr 2026 14:28:30 +1000 [thread overview]
Message-ID: <review-overall-20260406153654.2094908-1-magnus@alefors.se> (raw)
In-Reply-To: <20260406153654.2094908-1-magnus@alefors.se>
Overall Series Review
Subject: drm/imx/ipuv3: do not adjust hactive for non-8-pixel-aligned modes
Author: =?UTF-8?q?Magnus=20H=C3=B6rlin?= <magnus@alefors.se>
Patches: 2
Reviewed: 2026-04-12T14:28:30.850076
---
This is a single patch that removes the 8-pixel alignment rounding of `hactive` in the IPUv3 display driver, motivated by fixing visible skewing on displays whose native width is not 8-pixel aligned (e.g. 854x480). The approach is reasonable and the commit message is well-written with clear motivation.
The core argument is sound: `ipu_calculate_bursts()` already handles arbitrary widths mathematically, and the foreground plane (`SYNC_FG`) path already uses unaligned widths without issue. However, I have a few concerns about completeness and potential side effects.
**Verdict:** The change looks correct in principle but would benefit from addressing a couple of points before merging.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 15:36 [PATCH] drm/imx/ipuv3: do not adjust hactive for non-8-pixel-aligned modes Magnus Hörlin
2026-04-07 7:02 ` Philipp Zabel
2026-04-12 4:28 ` Claude Code Review Bot [this message]
2026-04-12 4:28 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260406153654.2094908-1-magnus@alefors.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox