From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Handle DETACH_DEBUG_BO through config_debug_bo path
Date: Sun, 12 Apr 2026 14:24:28 +1000 [thread overview]
Message-ID: <review-overall-20260406211403.4011988-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260406211403.4011988-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Handle DETACH_DEBUG_BO through config_debug_bo path
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 3
Reviewed: 2026-04-12T14:24:28.973286
---
This is a single-patch fix for the `accel/amdxdna` driver. The bug is clear and the fix is correct: `DETACH_DEBUG_BO` commands submitted via `amdxdna_cmd_submit()` (at `aie2_ctx.c:883`) would hit the `default` case in `aie2_sched_job_run()` and return `-EINVAL`, because only `ATTACH_DEBUG_BO` was handled in the switch statement. The downstream handler `aie2_config_debug_bo()` already distinguishes between attach and detach via the opcode (line 1179 of `aie2_message.c`), so routing both opcodes to that function is the correct approach.
The patch is minimal, well-targeted, and has an appropriate `Fixes:` tag.
One minor style nit below, but functionally this looks good to merge.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 4:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 21:14 [PATCH V1] accel/amdxdna: Handle DETACH_DEBUG_BO through config_debug_bo path Lizhi Hou
2026-04-06 21:29 ` Mario Limonciello
2026-04-07 17:23 ` Lizhi Hou
2026-04-12 4:24 ` Claude Code Review Bot [this message]
2026-04-12 4:24 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260406211403.4011988-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox