Claude review: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patches: 14
Reviewed: 2026-04-12T13:37:33.436594

---

This is a well-structured 11-patch series that migrates the i.MX8MP LCDIF driver from the legacy connector model to the modern `DRM_BRIDGE_ATTACH_NO_CONNECTOR` + bridge-connector pattern. The series is well organized: patches 1-4 are cleanups, patch 5-6 document and add safety checks to dw-hdmi, patch 7 resolves a devlink chicken-egg problem, patches 8-9 handle backward compatibility via a DT overlay fixup, patch 10 enables the new mode for imx8mp-hdmi-tx, and patch 11 does the actual LCDIF conversion.

The series shows good engineering discipline -- the backward-compatibility concern for boards without an `hdmi-connector` DT node is well thought out, the DT overlay approach reuses an existing pattern (tilcdc), and the series has gathered extensive testing and review tags from prior revisions.

There is one notable bug in patch 8 (error handling logic is inverted) and a potential bridge refcount lifetime concern in patch 7. The cleanup patches (1-4) and documentation patches (5-6) are straightforward and correct.

**Recommendation**: Address the bug in patch 8 and the lifetime concern in patch 7 before merging. The rest looks good.

---

---
Generated by Claude Code Patch Reviewer