From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector
Date: Tue, 31 Mar 2026 16:54:42 +1000 [thread overview]
Message-ID: <review-overall-20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com> (raw)
In-Reply-To: <20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com>
Overall Series Review
Subject: drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patches: 11
Reviewed: 2026-03-31T16:54:42.874753
---
This is a well-structured 10-patch series that modernizes the i.MX8MP LCDIF driver to use `DRM_BRIDGE_ATTACH_NO_CONNECTOR` with the `drm_bridge_connector` framework, which is the current DRM best practice. The series is logically ordered: patches 1-4 are clean preparatory cleanups to lcdif_drv.c, patches 5-6 improve dw-hdmi documentation and validation, patch 7 resolves a devlink/probe-ordering problem, patch 8 provides DT backward compatibility via an overlay, patch 9 enables the new mode in imx8mp-hdmi-tx, and patch 10 makes the final LCDIF conversion.
The approach is sound and the backward-compatibility strategy using DT overlays (following the tilcdc precedent) is reasonable. The series deserves broad hardware testing given the regression potential on i.MX8MP HDMI boards.
A few issues noted below, mostly minor, with one moderate concern in patch 7 and one dead-variable issue in patch 8.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 6:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 19:25 [PATCH v2 00/10] drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Luca Ceresoli
2026-03-30 19:25 ` [PATCH v2 01/10] drm/mxsfb/lcdif: simplify remote pointer management using __free Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 02/10] drm/mxsfb/lcdif: simplify ep " Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 03/10] drm/mxsfb/lcdif: use dev_err_probe() consistently in lcdif_attach_bridge Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 04/10] drm/mxsfb/lcdif: lcdif_attach_bridge: move iteration-specific variables declaration inside loop Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 06/10] drm/bridge: dw-hdmi: warn on unsupported attach combination Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 07/10] drm/bridge: dw-hdmi: move next_bridge lookup to attach time Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 08/10] drm/bridge: imx8mp-hdmi-tx: add an hdmi-connector when missing using a DT overlay at boot time Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 09/10] drm/bridge: imx8mp-hdmi-tx: switch to DRM_BRIDGE_ATTACH_NO_CONNECTOR Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 10/10] drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-31 6:54 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-04-07 12:24 [PATCH v4 00/11] " Luca Ceresoli
2026-04-07 12:24 ` [PATCH v4 11/11] " Luca Ceresoli
2026-04-12 3:37 ` Claude review: " Claude Code Review Bot
2026-04-12 3:37 ` Claude Code Review Bot
2026-03-20 10:46 [PATCH 0/8] " Luca Ceresoli
2026-03-20 10:46 ` [PATCH 8/8] " Luca Ceresoli
2026-03-21 17:48 ` Claude review: " Claude Code Review Bot
2026-03-21 17:48 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260330-drm-lcdif-dbanc-v2-0-c7f2af536a24@bootlin.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox