From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: imx8mp-hdmi-tx: add an hdmi-connector when missing using a DT overlay at boot time
Date: Tue, 31 Mar 2026 16:54:44 +1000 [thread overview]
Message-ID: <review-patch8-20260330-drm-lcdif-dbanc-v2-8-c7f2af536a24@bootlin.com> (raw)
In-Reply-To: <20260330-drm-lcdif-dbanc-v2-8-c7f2af536a24@bootlin.com>
Patch Review
**Dead variable:** `hdmi_conn` is declared with `__free(device_node)` but is never assigned or used anywhere in the function. This should be removed.
```c
struct device_node *hdmi_conn __free(device_node) = NULL; // unused
```
**Minor typos in commit message:** "device tre" should be "device tree", "isntantiating" should be "instantiating", "abd" should be "and".
**Error handling for `of_overlay_fdt_apply`:** The function returns `of_overlay_fdt_apply(...)` directly. If the overlay application fails, this returns an error from a `subsys_initcall`, which will be logged but won't prevent boot. This seems acceptable — the HDMI output simply won't work, which is a degraded but not catastrophic failure.
**Hardcoded paths:** The code uses hardcoded DT paths like `/soc@0/bus@32c00000/hdmi@32fd8000`. These are specific to the i.MX8MP SoC and the compatible check (`fsl,imx8mp-soc`) guards against running on other hardware. This is reasonable for a fixup module.
**Kconfig:** The `DRM_IMX8MP_DW_HDMI_BRIDGE_CONNECTOR_FIXUP` is a `bool` with `default y` — it's always built when both LCDIF and HDMI bridge are enabled. The `select OF_OVERLAY` and `select DRM_DISPLAY_CONNECTOR` on the parent config are appropriate.
**The overlay itself** looks correct — it adds the `fixup-hdmi-connector` node at root level and adds a `port@1/endpoint` to the existing hdmi node with proper remote-endpoint phandle linkage.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 6:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 19:25 [PATCH v2 00/10] drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Luca Ceresoli
2026-03-30 19:25 ` [PATCH v2 01/10] drm/mxsfb/lcdif: simplify remote pointer management using __free Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 02/10] drm/mxsfb/lcdif: simplify ep " Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 03/10] drm/mxsfb/lcdif: use dev_err_probe() consistently in lcdif_attach_bridge Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 04/10] drm/mxsfb/lcdif: lcdif_attach_bridge: move iteration-specific variables declaration inside loop Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 05/10] drm/bridge: dw-hdmi: document the output_port field Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 06/10] drm/bridge: dw-hdmi: warn on unsupported attach combination Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 07/10] drm/bridge: dw-hdmi: move next_bridge lookup to attach time Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 08/10] drm/bridge: imx8mp-hdmi-tx: add an hdmi-connector when missing using a DT overlay at boot time Luca Ceresoli
2026-03-31 6:54 ` Claude Code Review Bot [this message]
2026-03-30 19:25 ` [PATCH v2 09/10] drm/bridge: imx8mp-hdmi-tx: switch to DRM_BRIDGE_ATTACH_NO_CONNECTOR Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-30 19:25 ` [PATCH v2 10/10] drm/mxsfb/lcdif: use DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector Luca Ceresoli
2026-03-31 6:54 ` Claude review: " Claude Code Review Bot
2026-03-31 6:54 ` Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-03-20 10:46 [PATCH 0/8] " Luca Ceresoli
2026-03-20 10:46 ` [PATCH 7/8] drm/bridge: imx8mp-hdmi-tx: add an hdmi-connector when missing using a DT overlay at boot time Luca Ceresoli
2026-03-21 17:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260330-drm-lcdif-dbanc-v2-8-c7f2af536a24@bootlin.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox