From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: imx952: Describe Mali G310 GPU
Date: Sun, 12 Apr 2026 14:13:24 +1000 [thread overview]
Message-ID: <review-overall-20260407-master-v3-1-5a05cea0c521@nxp.com> (raw)
In-Reply-To: <20260407-master-v3-1-5a05cea0c521@nxp.com>
Overall Series Review
Subject: arm64: dts: imx952: Describe Mali G310 GPU
Author: Guangliu Ding <guangliu.ding@nxp.com>
Patches: 2
Reviewed: 2026-04-12T14:13:24.488598
---
This is a single patch (v3) adding a device tree description for the Mali G310 GPU on the i.MX952 SoC. The patch adds an OPP table and a GPU device node to `imx952.dtsi`, mirroring the existing GPU definition in `imx95.dtsi` since both SoCs use the same Mali G310 GPU IP block.
The patch is mostly straightforward and follows the existing imx95 GPU node as a template. There are two items worth discussing — one potentially significant (missing clock) and one minor (missing cooling-cells).
**Verdict**: Patch needs clarification on the missing `coregroup` clock, and the missing `#cooling-cells` should be explained or added.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 4:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 3:15 [PATCH v3] arm64: dts: imx952: Describe Mali G310 GPU Guangliu Ding
2026-04-08 13:56 ` Liviu Dudau
2026-04-12 4:13 ` Claude review: " Claude Code Review Bot
2026-04-12 4:13 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260407-master-v3-1-5a05cea0c521@nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox