From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()
Date: Sun, 12 Apr 2026 13:22:17 +1000 [thread overview]
Message-ID: <review-overall-20260407144142.1420354-2-ivitro@gmail.com> (raw)
In-Reply-To: <20260407144142.1420354-2-ivitro@gmail.com>
Overall Series Review
Subject: drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS()
Author: Vitor Soares <ivitro@gmail.com>
Patches: 1
Reviewed: 2026-04-12T13:22:17.990676
---
This is a single well-motivated bugfix patch that replaces the deprecated `UNIVERSAL_DEV_PM_OPS()` macro with runtime-PM-only ops in the Cadence DSI bridge driver. The problem is clearly described: `UNIVERSAL_DEV_PM_OPS` registers the same callbacks for both system sleep *and* runtime PM, causing clocks to be disabled twice during system suspend (once via runtime PM, once via system sleep), triggering a clock framework warning.
The fix is correct and appropriate. The driver already uses `pm_runtime_get_sync()` / `pm_runtime_put()` in its bridge `atomic_pre_enable` / `atomic_post_disable` callbacks (lines 736 and 631), so the DRM framework already manages the system suspend/resume path through the bridge lifecycle. Only the runtime PM callbacks are needed at the driver PM ops level.
The patch has a Reviewed-by from Tomi Valkeinen and a Fixes tag with stable CC. It is in good shape for merging.
**Verdict: Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:41 [PATCH v4] drm/bridge: cdns-dsi: Replace deprecated UNIVERSAL_DEV_PM_OPS() Vitor Soares
2026-04-12 3:22 ` Claude Code Review Bot [this message]
2026-04-12 3:22 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260407144142.1420354-2-ivitro@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox