From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/i915/dp: Clear accumulated HPD events after link training
Date: Sun, 12 Apr 2026 12:53:17 +1000 [thread overview]
Message-ID: <review-overall-20260408084509.555045-1-acelan.kao@canonical.com> (raw)
In-Reply-To: <20260408084509.555045-1-acelan.kao@canonical.com>
Overall Series Review
Subject: drm/i915/dp: Clear accumulated HPD events after link training
Author: "Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>
Patches: 1
Reviewed: 2026-04-12T12:53:17.132011
---
This is a single, well-focused patch addressing a real hardware issue: GPU hard lockups on MST hubs (specifically Dell U2721DE with Realtek MST hub) caused by stale HPD events being replayed after link training completes.
The fix is minimal and uses an existing API (`intel_hpd_clear_and_unblock()`) that was designed precisely for this purpose — it is already used in `intel_crt.c:575` for an analogous "discard stale events after detection" scenario. The approach is sound: events accumulated while HPD was blocked during link training are stale (they reflect pre-retrain link state), and processing them after a successful retrain creates a burst of work that races with the modeset pipeline. The scheduled `intel_encoder_link_check_queue_work()` call at line 1161 provides a safety net for detecting any legitimate link issues post-retrain.
**Verdict: Looks good.** One minor observation below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 8:45 [PATCH] drm/i915/dp: Clear accumulated HPD events after link training Chia-Lin Kao (AceLan)
2026-04-12 2:53 ` Claude Code Review Bot [this message]
2026-04-12 2:53 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260408084509.555045-1-acelan.kao@canonical.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox