From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: rcar-du: Fix crash when no CMM is available
Date: Sun, 12 Apr 2026 12:28:44 +1000 [thread overview]
Message-ID: <review-overall-20260408124205.1962448-1-laurent.pinchart+renesas@ideasonboard.com> (raw)
In-Reply-To: <20260408124205.1962448-1-laurent.pinchart+renesas@ideasonboard.com>
Overall Series Review
Subject: drm: rcar-du: Fix crash when no CMM is available
Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Patches: 2
Reviewed: 2026-04-12T12:28:44.829717
---
This is a single-patch fix for a NULL pointer dereference crash in the R-Car DU driver. The bug is straightforward: commit 3bce3fdd1ff2 refactored CMM handling to use a `struct rcar_du_cmm *cmm` pointer (which contains a `dev` field), but the null-checks were written as `rcrtc->cmm->dev` instead of `rcrtc->cmm`. When no CMM is present, `rcrtc->cmm` is NULL (it's only assigned at `rcar_du_crtc.c:1304` when `rcdu->cmms[swindex].dev` is non-NULL), so dereferencing it to access `->dev` crashes.
The fix is correct, minimal, and well-targeted. The Fixes tag, Reported-by, and Tested-by are all present. This is a clean bug fix suitable for merging.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 12:42 [PATCH] drm: rcar-du: Fix crash when no CMM is available Laurent Pinchart
2026-04-10 5:20 ` Tomi Valkeinen
2026-04-12 2:28 ` Claude Code Review Bot [this message]
2026-04-12 2:28 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260408124205.1962448-1-laurent.pinchart+renesas@ideasonboard.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox