From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/sched: Add test suite for concurrent job submissions
Date: Sun, 12 Apr 2026 12:16:53 +1000 [thread overview]
Message-ID: <review-overall-20260408154947.85204-1-marco.pagani@linux.dev> (raw)
In-Reply-To: <20260408154947.85204-1-marco.pagani@linux.dev>
Overall Series Review
Subject: drm/sched: Add test suite for concurrent job submissions
Author: Marco Pagani <marco.pagani@linux.dev>
Patches: 7
Reviewed: 2026-04-12T12:16:53.731140
---
This is a single patch (v2) that adds a new KUnit test suite for concurrent job submissions to the DRM GPU scheduler. The patch is well-structured and addresses a genuine gap in test coverage — the existing tests all submit jobs from a single thread, whereas real GPU workloads involve concurrent submissions from multiple userspace contexts.
The patch introduces two test cases: (1) parallel bulk submission followed by manual timeline advance, and (2) interleaved submission with automatic duration-based completion using a sliding window. Both are parameterized, though each currently has only a single parameter set.
The code is generally clean and follows reasonable patterns. It introduces `KUNIT_DEFINE_ACTION_WRAPPER` and `kunit_add_action_or_reset` for cleanup, which is a departure from the existing `init`/`exit` pattern used by the other suites in this file, but is arguably better suited for the more complex resource lifecycle in concurrent tests. There are a few issues worth discussing.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 2:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 15:49 [PATCH v2] drm/sched: Add test suite for concurrent job submissions Marco Pagani
2026-04-09 15:35 ` Tvrtko Ursulin
2026-04-10 7:41 ` Tvrtko Ursulin
2026-04-10 10:30 ` Marco Pagani
2026-04-10 9:07 ` Marco Pagani
2026-04-10 9:19 ` Philipp Stanner
2026-04-10 11:33 ` Marco Pagani
2026-04-12 2:16 ` Claude review: " Claude Code Review Bot
2026-04-12 2:16 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260408154947.85204-1-marco.pagani@linux.dev \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox