From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: uapi: Add macro for chipset specific event ID region
Date: Sun, 12 Apr 2026 12:13:17 +1000 [thread overview]
Message-ID: <review-overall-20260408163608.361826-2-bence.csokas@arm.com> (raw)
In-Reply-To: <20260408163608.361826-2-bence.csokas@arm.com>
Overall Series Review
Subject: drm: uapi: Add macro for chipset specific event ID region
Author: Bence Csokas <bence.csokas@arm.com>
Patches: 1
Reviewed: 2026-04-12T12:13:17.431218
---
This is a single patch that introduces a `DRM_EVENT_VENDOR_SPECIFIC(_v)` macro to codify the existing convention that DRM event types `>= 0x80000000` are reserved for chipset/driver-specific use. The concept is sound — elevating a comment-only contract into a code-enforced convention is good practice for UAPI headers.
However, the patch has one notable omission: `nouveau_drm.h` defines `DRM_NOUVEAU_EVENT_NVIF` as `0x80000000` (line 28) but was not converted. This appears to be because in `nouveau_drm.h` the define appears *before* the `#include "drm.h"` (line 30), so the macro wouldn't be available at the point of use. This is a valid technical obstacle, but it should be explicitly called out in the commit message. Silently skipping one of the four vendor-specific event definitions without explanation undermines the goal of making the conversion comprehensive.
The macro values are all numerically correct — every converted definition produces the same value as before.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 2:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 16:36 [PATCH] drm: uapi: Add macro for chipset specific event ID region Bence Csokas
2026-04-12 2:13 ` Claude review: " Claude Code Review Bot
2026-04-12 2:13 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260408163608.361826-2-bence.csokas@arm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox