From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: stm_lvds: Do not fail atomic_check on disabled connector
Date: Sun, 12 Apr 2026 11:47:57 +1000 [thread overview]
Message-ID: <review-overall-20260409024928.344010-1-marex@nabladev.com> (raw)
In-Reply-To: <20260409024928.344010-1-marex@nabladev.com>
Overall Series Review
Subject: drm/bridge: stm_lvds: Do not fail atomic_check on disabled connector
Author: Marek Vasut <marex@nabladev.com>
Patches: 1
Reviewed: 2026-04-12T11:47:57.467444
---
This is a single-patch fix for the STM32 LVDS bridge driver. The change is small, correct, and well-motivated: when the connector is disabled (i.e., `conn_state->crtc` is NULL), the `atomic_check` callback should return success (0) rather than `-EINVAL`, because a disabled connector is a perfectly valid state. The original code treated a NULL crtc as an error, which caused suspend/resume to fail when `atomic_check` was called on an already-disabled connector.
The fix is clean and follows the same pattern used by other DRM drivers (analogix_dp, vmwgfx, vkms).
**Verdict: Looks good to apply.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 1:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 2:48 [PATCH] drm/bridge: stm_lvds: Do not fail atomic_check on disabled connector Marek Vasut
2026-04-12 1:47 ` Claude Code Review Bot [this message]
2026-04-12 1:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260409024928.344010-1-marex@nabladev.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox