From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add clear-error-counter command to drm_ras
Date: Sun, 12 Apr 2026 11:34:39 +1000 [thread overview]
Message-ID: <review-overall-20260409073318.2909379-4-riana.tauro@intel.com> (raw)
In-Reply-To: <20260409073318.2909379-4-riana.tauro@intel.com>
Overall Series Review
Subject: Add clear-error-counter command to drm_ras
Author: Riana Tauro <riana.tauro@intel.com>
Patches: 8
Reviewed: 2026-04-12T11:34:39.897653
---
This is a clean, well-structured 2-patch series that adds a `clear-error-counter` netlink command to the DRM RAS subsystem and implements it in the XE driver. The new command follows the established patterns from the existing `get-error-counter` command closely, making it easy to review. The YAML spec, UAPI, core framework, and driver callback are all properly wired up.
The series has already received Reviewed-by from Jakub Kicinski (patch 1, netlink aspects) and Raag Jadav (both patches). I have one functional concern about the error code when a driver doesn't implement the callback, and a few minor observations.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 1:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 7:33 [PATCH v2 0/2] Add clear-error-counter command to drm_ras Riana Tauro
2026-04-09 7:33 ` [PATCH v2 1/2] drm/drm_ras: Add clear-error-counter netlink " Riana Tauro
2026-04-09 7:21 ` Tauro, Riana
2026-04-09 13:37 ` Rodrigo Vivi
2026-04-10 5:21 ` Tauro, Riana
2026-04-09 23:01 ` Zack McKevitt
2026-04-10 5:25 ` Tauro, Riana
2026-04-12 1:34 ` Claude review: " Claude Code Review Bot
2026-04-09 7:33 ` [PATCH v2 2/2] drm/xe/xe_drm_ras: Add support for clear-error-counter in XE drm_ras Riana Tauro
2026-04-12 1:34 ` Claude review: " Claude Code Review Bot
2026-04-12 1:34 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260409073318.2909379-4-riana.tauro@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox