Claude review: drm/xe/xe_drm_ras: Add support for clear-error-counter in XE drm_ras

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Overall**: Straightforward driver-side implementation that closely follows the existing query callback pattern. No issues.

**`hw_clear_error_counter()`** correctly mirrors `hw_query_error_counter()`:

```c
static int hw_clear_error_counter(struct xe_drm_ras_counter *info, u32 error_id)
{
	if (!info || !info[error_id].name)
		return -ENOENT;

	atomic_set(&info[error_id].counter, 0);

	return 0;
}
```

The bounds safety is guaranteed by the core framework's range check (against `error_counter_range.first`/`.last`) before the callback is invoked, so the array access `info[error_id]` is safe. The `!info[error_id].name` check handles non-contiguous IDs gracefully.

**`atomic_set` for clearing** is appropriate — it matches the `atomic_read` in the query path and any `atomic_inc` in the error recording path. There is an inherent TOCTOU between clearing and the next read (a new error could arrive), but that's fundamental to the operation and not a bug.

**Code structure observation**: The `clear_uncorrectable_error_counter()` and `clear_correctable_error_counter()` functions are near-identical, differing only in the severity index used to select `ras->info[severity]`. The same duplication exists in the query callbacks. This is fine for two severities, but if more are added, a single parameterized function with a severity argument stored in the node's `priv` (or a wrapper struct) would be cleaner. Not a blocking concern for this series.

**`assign_node_params()` modification** is clean — adding braces around the existing if/else and inserting the callback assignment alongside the query callback:

```c
	if (severity == DRM_XE_RAS_ERR_SEV_CORRECTABLE) {
		node->query_error_counter = query_correctable_error_counter;
		node->clear_error_counter = clear_correctable_error_counter;
	} else {
		node->query_error_counter = query_uncorrectable_error_counter;
		node->clear_error_counter = clear_uncorrectable_error_counter;
	}
```

No issues with this patch.

---
Generated by Claude Code Patch Reviewer