From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm/tests: Remove checks from ttm_pool_free_no_dma_alloc
Date: Sun, 12 Apr 2026 11:03:53 +1000 [thread overview]
Message-ID: <review-overall-20260409142658.1511941-2-dev@lankhorst.se> (raw)
In-Reply-To: <20260409142658.1511941-2-dev@lankhorst.se>
Overall Series Review
Subject: drm/ttm/tests: Remove checks from ttm_pool_free_no_dma_alloc
Author: Maarten Lankhorst <dev@lankhorst.se>
Patches: 1
Reviewed: 2026-04-12T11:03:53.106940
---
This is a single-patch fix that removes broken assertions from the `ttm_pool_free_no_dma_alloc` kunit test. The fix is correct and appropriate as a CI-unblocking measure. The root cause is well-identified: without `TTM_ALLOCATION_POOL_USE_DMA_ALLOC`, `ttm_pool_select_type()` does not return the pool's own `pool->caching[caching].orders[order]` entry — on x86 it returns a global pool, and on !x86 it returns NULL. In both cases, the per-pool `ttm_pool_type` is never initialized via `ttm_pool_type_init()`, so calling `list_lru_count()` on it is invalid.
The patch is a reasonable quick fix to unbreak CI. The test still exercises the alloc/free path itself, but it no longer verifies any postconditions.
**Recommendation: Accept**, with minor nits below.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 14:26 [PATCH] drm/ttm/tests: Remove checks from ttm_pool_free_no_dma_alloc Maarten Lankhorst
2026-04-12 1:03 ` Claude review: " Claude Code Review Bot
2026-04-12 1:03 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260409142658.1511941-2-dev@lankhorst.se \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox