From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Expose per-client BO memory usage via fdinfo
Date: Sun, 12 Apr 2026 11:06:37 +1000 [thread overview]
Message-ID: <review-overall-20260409152259.176883-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260409152259.176883-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Expose per-client BO memory usage via fdinfo
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 3
Reviewed: 2026-04-12T11:06:37.322159
---
This is a single patch adding per-client BO memory usage reporting via the fdinfo interface to the amdxdna accel driver. The approach is sound and follows established patterns used by other drivers (e.g., panthor). The patch hooks `drm_show_fdinfo` into file_operations and provides a custom `show_fdinfo` callback in `drm_driver` that reports driver-specific memory categories before calling `drm_show_memory_stats()` for the standard DRM memory stats.
The implementation is straightforward and mostly correct. There are a few issues worth addressing — one potential unsigned underflow, a type width concern, and minor style/doc nits.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 1:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 15:22 [PATCH V1] accel/amdxdna: Expose per-client BO memory usage via fdinfo Lizhi Hou
2026-04-09 17:02 ` Mario Limonciello
2026-04-09 20:46 ` Lizhi Hou
2026-04-12 1:06 ` Claude review: " Claude Code Review Bot
2026-04-12 1:06 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260409152259.176883-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox