From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Remove unused header in drm_dumb_buffers.c
Date: Sun, 12 Apr 2026 10:55:27 +1000 [thread overview]
Message-ID: <review-overall-20260409154826.8955-1-yiconghui@gmail.com> (raw)
In-Reply-To: <20260409154826.8955-1-yiconghui@gmail.com>
Overall Series Review
Subject: drm: Remove unused header in drm_dumb_buffers.c
Author: Yicong Hui <yiconghui@gmail.com>
Patches: 1
Reviewed: 2026-04-12T10:55:27.497281
---
This is a single-patch series that removes an unused `#include "drm_internal.h"` from `drm_dumb_buffers.c`. The change is trivially correct.
The commit message is well-written: it explains the provenance of the include (added by commit `47f10854ca89` when functions were moved to this file) and why it became unnecessary (commit `96a7b60f6ddb` removed `drm_gem_dumb_destroy`, which was the last user of declarations from that header). The testing described (build with DRM enabled, kunit, IGT in a VM) is appropriate for the scope.
**Verdict: Looks good.** No issues found.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 0:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 15:48 [PATCH] drm: Remove unused header in drm_dumb_buffers.c Yicong Hui
2026-04-12 0:55 ` Claude Code Review Bot [this message]
2026-04-12 0:55 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260409154826.8955-1-yiconghui@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox