From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Remove unused header in drm_dumb_buffers.c
Date: Sun, 12 Apr 2026 10:55:27 +1000 [thread overview]
Message-ID: <review-patch1-20260409154826.8955-1-yiconghui@gmail.com> (raw)
In-Reply-To: <20260409154826.8955-1-yiconghui@gmail.com>
Patch Review
**Result: No issues.**
The patch removes:
```c
-#include "drm_internal.h"
```
I verified this is correct by cross-referencing the symbols used in `drm_dumb_buffers.c` against the declarations in `drm_internal.h`:
- `drm_gem_handle_delete()` — declared in `<drm/drm_gem.h>` (line 584), **not** in `drm_internal.h`
- `drm_gem_dumb_map_offset()` — declared in `<drm/drm_gem.h>`, **not** in `drm_internal.h`
- `drm_mode_create_dumb_ioctl()`, `drm_mode_mmap_dumb_ioctl()`, `drm_mode_destroy_dumb_ioctl()` — declared in `drm_crtc_internal.h` (lines 116-120), which remains included
- All other symbols come from the public `<drm/*.h>` headers already included
No symbol used by `drm_dumb_buffers.c` is declared in `drm_internal.h`. The remaining include of `drm_crtc_internal.h` covers the internal declarations this file needs.
The `Fixes:` tag referencing `96a7b60f6ddb` is reasonable — that's the commit that removed `drm_gem_dumb_destroy()`, which was the last function requiring `drm_internal.h`. Minor nit: some maintainers might prefer not to use a `Fixes:` tag for a cosmetic cleanup since nothing is functionally broken, but this is a matter of style/preference and not worth blocking on.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 0:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 15:48 [PATCH] drm: Remove unused header in drm_dumb_buffers.c Yicong Hui
2026-04-12 0:55 ` Claude review: " Claude Code Review Bot
2026-04-12 0:55 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260409154826.8955-1-yiconghui@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox