From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: udlfb: avoid divide-by-zero on FBIOPUT_VSCREENINFO
Date: Sun, 12 Apr 2026 11:08:13 +1000 [thread overview]
Message-ID: <review-overall-2026040945-glare-devouring-f242@gregkh> (raw)
In-Reply-To: <2026040945-glare-devouring-f242@gregkh>
Overall Series Review
Subject: fbdev: udlfb: avoid divide-by-zero on FBIOPUT_VSCREENINFO
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Patches: 2
Reviewed: 2026-04-12T11:08:13.381342
---
This is a single-patch series from Greg Kroah-Hartman that adds a divide-by-zero guard in the udlfb framebuffer driver's `check_var` callback. The fix is straightforward, correct, and follows an established pattern already applied to other fbdev drivers (e.g., `pm2fb` in commit 19f953e74356). The divide-by-zero can be triggered from userspace via the `FBIOPUT_VSCREENINFO` ioctl, which passes a user-controlled `fb_var_screeninfo` into the driver. The patch is minimal, well-placed, and appropriate for stable backporting.
**Verdict: Looks good.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 1:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 13:23 [PATCH] fbdev: udlfb: avoid divide-by-zero on FBIOPUT_VSCREENINFO Greg Kroah-Hartman
2026-04-10 14:55 ` Helge Deller
2026-04-12 1:08 ` Claude Code Review Bot [this message]
2026-04-12 1:08 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-2026040945-glare-devouring-f242@gregkh \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox