Claude review: fbdev: udlfb: avoid divide-by-zero on FBIOPUT_VSCREENINFO

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Issue being fixed:** In `dlfb_set_video_mode()` at line 271 of `udlfb.c`, the driver computes:
```c
200*1000*1000/var->pixclock
```
If `var->pixclock` is zero, this is a divide-by-zero crash. The `var` struct originates from userspace via `FBIOPUT_VSCREENINFO`, so a malicious or buggy application can trigger this. The fbdev core calls `check_var` before `set_par`, so validating in `dlfb_ops_check_var()` is the correct place to catch it early.

**The fix:**
```c
+	if (!var->pixclock)
+		return -EINVAL;
```

This is placed at the top of `dlfb_ops_check_var()`, before `dlfb_var_color_format(var)` and `fb_var_to_videomode()`. This is correct — there's no reason to proceed with any mode validation if pixclock is zero, since the mode would be unusable regardless.

**Minor observations:**

1. The placement before `dlfb_var_color_format()` is fine — that function only touches color fields, not pixclock — but placing it first is slightly more defensive and avoids unnecessary work on an invalid input. Good choice.

2. There's a second call site for `dlfb_set_video_mode()` at line 1106 (in `dlfb_ops_open()` which re-sets the current mode). That path uses `info->var` which should have already passed through `check_var`, so it's covered. Correct.

3. The `Fixes:` tag pointing to commit 59277b679f8b ("Staging: udlfb: add dynamic modeset support") is appropriate — that's the commit that introduced `dlfb_ops_check_var()` and the division via `dlfb_set_video_mode()`.

4. The `Assisted-by: gregkh_clanker_t1000` tag is a non-standard tag (not in the usual kernel tag vocabulary). This likely indicates AI assistance. There's been ongoing discussion in the kernel community about the appropriate tag for AI-assisted contributions; this may want to follow whatever convention the community settles on, but it's not a blocking issue.

**Verdict: Reviewed-by worthy.** The patch is correct, minimal, and well-targeted. No issues found.

---
Generated by Claude Code Patch Reviewer