public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: ti, am65x-dss: Fix AM62L DSS reg and clock constraints
Date: Sun, 12 Apr 2026 09:43:11 +1000	[thread overview]
Message-ID: <review-overall-20260410105955.843868-1-s-jain1@ti.com> (raw)
In-Reply-To: <20260410105955.843868-1-s-jain1@ti.com>

Overall Series Review

Subject: dt-bindings: display: ti, am65x-dss: Fix AM62L DSS reg and clock constraints
Author: Swamil Jain <s-jain1@ti.com>
Patches: 2
Reviewed: 2026-04-12T09:43:11.719203

---

This is a single patch (v3) fixing the DT binding for the AM62L DSS in `ti,am65x-dss.yaml`. The AM62L DSS has a single video port with only a "lite plane" (no VID plane, no OVR2, no VP2), but the original AM62L binding addition incorrectly reused the same 8-register, 3-clock constraints as the dual-video-port AM65x/AM625/AM62A7 variants.

The fix is well-structured and uses two complementary mechanisms:
1. `oneOf` at the property level for `reg`/`reg-names` to define both valid register layouts (8-item for dual-VP and 5-item for AM62L).
2. `if`/`then`/`else` conditionals in `allOf` to bind the correct register/clock counts to the correct `compatible` string.

The approach is clean and follows established dt-binding conventions. The `Fixes:` and `Cc: stable` tags are appropriate since the original AM62L binding would have validated incorrectly (requiring 8 registers and 3 clocks that don't exist on AM62L hardware).

**Verdict: Patch looks correct and ready to apply, with minor observations noted below.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-11 23:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 10:59 [PATCH v3] dt-bindings: display: ti, am65x-dss: Fix AM62L DSS reg and clock constraints Swamil Jain
2026-04-11 14:07 ` Krzysztof Kozlowski
2026-04-11 23:43 ` Claude Code Review Bot [this message]
2026-04-11 23:43 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260410105955.843868-1-s-jain1@ti.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox