From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails
Date: Sun, 12 Apr 2026 09:26:10 +1000 [thread overview]
Message-ID: <review-overall-20260410195537.295119-1-osama.abdelkader@gmail.com> (raw)
In-Reply-To: <20260410195537.295119-1-osama.abdelkader@gmail.com>
Overall Series Review
Subject: drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails
Author: Osama Abdelkader <osama.abdelkader@gmail.com>
Patches: 1
Reviewed: 2026-04-12T09:26:10.914700
---
This is a single, straightforward bugfix patch that addresses a resource leak in the `chipone_i2c_probe()` error path. When `chipone_dsi_host_attach()` fails, the bridge added via `drm_bridge_add()` was not being cleaned up, leaving a stale bridge registered. The fix correctly mirrors the pattern already used in the sibling `chipone_dsi_probe()` function.
The fix is correct and minimal. One minor style nit exists.
**Verdict: Patch looks good with a minor nit.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-11 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 19:55 [PATCH] drm/bridge: chipone-icn6211: remove bridge when chipone_dsi_host_attach fails Osama Abdelkader
2026-04-11 23:26 ` Claude Code Review Bot [this message]
2026-04-11 23:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260410195537.295119-1-osama.abdelkader@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox