From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a6xx: Restore sysprof_active
Date: Sun, 12 Apr 2026 08:58:12 +1000 [thread overview]
Message-ID: <review-overall-20260411150312.257937-1-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260411150312.257937-1-robin.clark@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm/a6xx: Restore sysprof_active
Author: Rob Clark <robin.clark@oss.qualcomm.com>
Patches: 2
Reviewed: 2026-04-12T08:58:12.216601
---
This is a single-patch fix that restores a `.sysprof_setup` vfunc assignment that was accidentally dropped during a refactoring (commit 491fadb2b818, "drm/msm/adreno: Move adreno_gpu_func to catalogue"). Without this assignment, `a6xx_gmu_sysprof_setup()` is never called when userspace starts/stops performance counter collection, meaning IFPC (Idle Frequency Power Collapse) is not inhibited, causing perfcounter select register values to be lost during collapse.
The fix is correct and straightforward. One observation worth raising: `a8xx_gpu_funcs` also uses the same GMU infrastructure but does not have `.sysprof_setup` either, which could be a similar gap (though possibly a pre-existing one rather than a regression from the catalogue move).
**Verdict:** The patch looks good. One question for the author regarding a8xx coverage.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-11 22:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 15:03 [PATCH] drm/msm/a6xx: Restore sysprof_active Rob Clark
2026-04-11 21:18 ` Akhil P Oommen
2026-04-11 22:58 ` Claude Code Review Bot [this message]
2026-04-11 22:58 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260411150312.257937-1-robin.clark@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox