From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path
Date: Mon, 13 Apr 2026 19:12:54 +1000 [thread overview]
Message-ID: <review-overall-20260412120644.2449624-1-lgs201920130244@gmail.com> (raw)
In-Reply-To: <20260412120644.2449624-1-lgs201920130244@gmail.com>
Overall Series Review
Subject: gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path
Author: Guangshuo Li <lgs201920130244@gmail.com>
Patches: 1
Reviewed: 2026-04-13T19:12:54.751886
---
This is a single-patch fix for a device reference handling bug in the host1x bus driver. The analysis is correct and the fix is appropriate. After `device_initialize()` sets up the embedded `struct device` (including refcount = 1 and kobject internals), the proper teardown path is `put_device()`, not a raw `kfree()`. The patch is minimal, well-targeted, and the commit message adequately explains the rationale.
**Verdict: The patch is correct and should be accepted.**
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-13 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 12:06 [PATCH] gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path Guangshuo Li
2026-04-13 9:12 ` Claude Code Review Bot [this message]
2026-04-13 9:12 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-12 12:26 [PATCH v2] " Guangshuo Li
2026-04-13 9:07 ` Claude review: " Claude Code Review Bot
2026-04-13 9:07 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260412120644.2449624-1-lgs201920130244@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox