From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: staging: fbtft: fix coding style issue in fbtft-bus.c
Date: Mon, 13 Apr 2026 18:59:36 +1000 [thread overview]
Message-ID: <review-overall-20260412164953.1470-1-mzndmzn@gmail.com> (raw)
In-Reply-To: <20260412164953.1470-1-mzndmzn@gmail.com>
Overall Series Review
Subject: staging: fbtft: fix coding style issue in fbtft-bus.c
Author: Baker <mzndmzn@gmail.com>
Patches: 1
Reviewed: 2026-04-13T18:59:36.948669
---
**NAK — This patch is incorrect and will break compilation.**
This is a single-patch "series" that attempts to fix a checkpatch.pl style warning by removing the trailing comma and empty 4th argument from two `define_fbtft_write_reg` macro invocations. However, the empty 4th argument is **intentional and functional** — it is not a style issue. Removing it changes the macro call from 4 arguments to 3, which will cause a preprocessor error since the macro is defined with exactly 4 parameters.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-13 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-12 16:49 [PATCH] staging: fbtft: fix coding style issue in fbtft-bus.c Baker
2026-04-13 8:59 ` Claude Code Review Bot [this message]
2026-04-13 8:59 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-12 17:21 [PATCH] staging: fbtft: replace empty macro args with identity converter Baker
2026-04-12 17:21 ` [PATCH] staging: fbtft: fix coding style issue in fbtft-bus.c Baker
2026-04-13 8:56 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260412164953.1470-1-mzndmzn@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox