Claude review: staging: fbtft: fix coding style issue in fbtft-bus.c

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Result: NAK — introduces a build break**

The macro `define_fbtft_write_reg` is defined at `fbtft-bus.c:14` with **4 parameters**:

```c
#define define_fbtft_write_reg(func, buffer_type, data_type, modifier)
```

The `modifier` parameter is used throughout the macro body as a function-like call, e.g. at line 42:

```c
*buf = modifier((data_type)va_arg(args, unsigned int));
```

When the 4th argument is left **empty** (as in the original code):

```c
define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
```

the preprocessor expands `modifier((data_type)va_arg(args, unsigned int))` to simply `((u8)va_arg(args, unsigned int))` — an identity operation wrapped in parentheses. This is a deliberate and well-known C preprocessor idiom for a "no-op modifier." Compare with line 66 where `cpu_to_be16` is passed as the modifier to perform byte-swapping:

```c
define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
```

The patch changes the invocations to only pass 3 arguments:

```c
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8)
```

This will produce a compilation error like:

> `error: macro "define_fbtft_write_reg" requires 4 arguments, but only 3 given`

The trailing comma before `)` is **not** a coding style issue — it is syntactically required to pass an empty 4th macro argument. checkpatch.pl's warning is a false positive in this context.

**If the author wishes to make this cleaner**, the correct approach would be to refactor the macro itself, for example by introducing a separate 3-parameter version without `modifier`, or by using variadic macros (`__VA_ARGS__`), or by defining a no-op modifier macro like `#define IDENTITY(x) (x)` and passing that instead of an empty argument. Simply dropping the argument is not valid.

---
Generated by Claude Code Patch Reviewer