From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev/offb: fix PCI device reference leak on probe failure
Date: Thu, 23 Apr 2026 10:29:37 +1000 [thread overview]
Message-ID: <review-overall-20260420010118.17960-1-dbgh9129@gmail.com> (raw)
In-Reply-To: <20260420010118.17960-1-dbgh9129@gmail.com>
Overall Series Review
Subject: fbdev/offb: fix PCI device reference leak on probe failure
Author: Yuho Choi <dbgh9129@gmail.com>
Patches: 1
Reviewed: 2026-04-23T10:29:37.182445
---
This is a single-patch series that fixes a PCI device reference leak in the `offb` framebuffer driver. The fix is correct and straightforward: `pci_get_device()` returns a device with an incremented reference count, and the original code failed to call `pci_dev_put()` when `pci_enable_device()` failed. The patch properly splits the combined condition to handle each failure case appropriately.
The Fixes tag correctly identifies commit 5bda8f7b5468 which introduced the `pci_enable_device()` call and thus the leaking error path.
**Verdict: The patch is correct and should be accepted**, with one observation about a pre-existing issue noted below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-23 0:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 1:01 [PATCH v1] fbdev/offb: fix PCI device reference leak on probe failure Yuho Choi
2026-04-23 0:29 ` Claude Code Review Bot [this message]
2026-04-23 0:29 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260420010118.17960-1-dbgh9129@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox