From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: savage: fix probe-path EDID cleanup leaks
Date: Thu, 23 Apr 2026 10:23:48 +1000 [thread overview]
Message-ID: <review-overall-20260420051926.28276-1-dbgh9129@gmail.com> (raw)
In-Reply-To: <20260420051926.28276-1-dbgh9129@gmail.com>
Overall Series Review
Subject: fbdev: savage: fix probe-path EDID cleanup leaks
Author: Yuho Choi <dbgh9129@gmail.com>
Patches: 1
Reviewed: 2026-04-23T10:23:48.511522
---
This is a single-patch series that fixes a real memory leak in the savagefb probe error path. The analysis is correct: when `CONFIG_FB_SAVAGE_I2C` is enabled, `savagefb_probe()` allocates both `info->monspecs.modedb` (via `fb_edid_to_monspecs`) and modelist entries (via `fb_videomode_to_modelist`), but the `failed:` cleanup label only deleted the I2C busses without freeing these allocations.
The fix is minimal, correct, and safe against double-free. **Recommend accept**, with one minor observation.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-23 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 5:19 [PATCH v1] fbdev: savage: fix probe-path EDID cleanup leaks Yuho Choi
2026-04-23 0:23 ` Claude review: " Claude Code Review Bot
2026-04-23 0:23 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260420051926.28276-1-dbgh9129@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox