Claude review: drm/amdgpu: Replace VKMS vblank timer with common implementation

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/amdgpu: Replace VKMS vblank timer with common implementation
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 2
Reviewed: 2026-04-23T09:48:28.476506

---

This is a single patch from Thomas Zimmermann that replaces amdgpu's custom VKMS vblank timer implementation with the shared DRM vblank helper infrastructure (`DRM_CRTC_VBLANK_TIMER_FUNCS` / `DRM_CRTC_HELPER_VBLANK_FUNCS`). The conversion is straightforward and correct. The shared helpers in `drm_vblank_helper.c` and `drm_vblank.c` provide equivalent functionality with improved robustness — particularly around deadlock avoidance in the cancel path and race handling in the timestamp function. The patch is a net deletion of ~120 lines, which is a strong positive.

The conversion looks functionally correct. The shared implementation handles the same cases as the removed code, with several improvements in the details. There is one minor cleanup opportunity worth noting.

**Verdict: Looks good overall. One minor nit about leftover dead fields.**

---

---
Generated by Claude Code Patch Reviewer