From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation
Date: Thu, 23 Apr 2026 09:01:58 +1000 [thread overview]
Message-ID: <review-overall-20260421012608.1474950-1-matthew.brost@intel.com> (raw)
In-Reply-To: <20260421012608.1474950-1-matthew.brost@intel.com>
Overall Series Review
Subject: drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation
Author: Matthew Brost <matthew.brost@intel.com>
Patches: 12
Reviewed: 2026-04-23T09:01:58.435382
---
This is a well-motivated 3-patch series addressing a real and well-documented pathological reclaim loop on Xe iGPU systems under memory fragmentation. The cover letter clearly describes the problem (kswapd → shrinker → eviction → rebind loop at ~2 FPS) and demonstrates measurable improvement (~10 FPS, restored buddyinfo).
The approach is sound: (1) teach TTM to only do reclaim at the order the driver actually benefits from, (2) tell TTM that Xe cares about order 9 (2MB), and (3) add a heuristic in the Xe shrinker to detect fragmentation-driven kswapd invocations and bail out early.
However, Patch 1 has a significant semantic expansion beyond what the commit message emphasizes, and Patch 3 has some robustness concerns around the ZONE_NORMAL hardcoding. Overall the series is reasonable but warrants discussion on these points.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-22 23:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 1:26 [PATCH 0/3] drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation Matthew Brost
2026-04-21 1:26 ` [PATCH 1/3] drm/ttm: Issue direct reclaim at beneficial_order Matthew Brost
2026-04-21 6:11 ` Christian König
2026-04-22 4:12 ` Matthew Brost
2026-04-22 6:41 ` Christian König
2026-04-22 7:32 ` Tvrtko Ursulin
2026-04-22 7:41 ` Christian König
2026-04-22 20:41 ` Matthew Brost
2026-04-22 23:01 ` Claude review: " Claude Code Review Bot
2026-04-21 1:26 ` [PATCH 2/3] drm/xe: Set TTM device beneficial_order to 9 (2M) Matthew Brost
2026-04-22 23:01 ` Claude review: " Claude Code Review Bot
2026-04-21 1:26 ` [PATCH 3/3] drm/xe: Avoid shrinker reclaim from kswapd under fragmentation Matthew Brost
2026-04-22 8:22 ` Thomas Hellström
2026-04-22 20:27 ` Matthew Brost
2026-04-22 23:01 ` Claude review: " Claude Code Review Bot
2026-04-22 23:01 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260421012608.1474950-1-matthew.brost@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox