From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: VKMS: Introduce multiple configFS attributes
Date: Thu, 23 Apr 2026 07:30:11 +1000 [thread overview]
Message-ID: <review-overall-20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com> (raw)
In-Reply-To: <20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com>
Overall Series Review
Subject: VKMS: Introduce multiple configFS attributes
Author: Louis Chauvet <louis.chauvet@bootlin.com>
Patches: 39
Reviewed: 2026-04-23T07:30:11.097813
---
This is a large 37-patch series by Louis Chauvet (Bootlin) adding configFS attributes to VKMS so userspace can configure plane properties (name, rotation, color encoding/range, formats, zpos), connector properties (type, colorspace, EDID), and dynamic connector creation (including MST PATH emulation). The series is well-structured: patches 1-5 export DRM core helpers, patch 6 is a rotation fix, patch 7 adds ABI documentation, patches 8-12 are cleanup, and patches 13-37 incrementally add config + configfs pairs for each feature.
The overall design is sound and the test coverage is commendable. However, I found several bugs, including a NULL-vs-ERR_PTR confusion in the hot-add path, a negative length calculation in format parsing, a lock-less rollback, format string misuse, and an API with misleading documentation. Several of these would cause crashes or data corruption at runtime.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-22 21:30 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 16:47 [PATCH v4 00/37] VKMS: Introduce multiple configFS attributes Louis Chauvet
2026-04-22 16:47 ` [PATCH v4 01/37] drm/drm_mode_config: Add helper to get plane type name Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:47 ` [PATCH v4 02/37] drm/blend: Get a rotation name from it's bitfield Louis Chauvet
2026-04-22 16:52 ` Ville Syrjälä
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 03/37] drm/drm_color_mgmt: Expose drm_get_color_encoding_name Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 04/37] drm/drm_color_mgmt: Expose drm_get_color_range_name Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 05/37] drm/connector: Export drm_get_colorspace_name Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 06/37] drm/drm_atomic_state_helper: Properly load default value for rotation Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 07/37] Documentation: ABI: vkms: Add current VKMS ABI documentation Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 08/37] drm/vkms: Add error handling in plane config creation Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 09/37] drm/vkms: Simplify plane_release code Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 10/37] drm/vkms: Explicitly display plane type Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 11/37] drm/vkms: Use enabled/disabled instead of 1/0 for debug Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 12/37] drm/vkms: Explicitly display connector status Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 13/37] drm/vkms: Introduce config for plane name Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 14/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 15/37] drm/vkms: Introduce config for plane rotation Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 16/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 17/37] drm/vkms: Introduce config for plane color encoding Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 18/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 19/37] drm/vkms: Introduce config for plane color range Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 20/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 21/37] drm/vkms: Introduce config for plane format Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 22/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 23/37] drm/vkms: Properly render plane using their zpos Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 24/37] drm/vkms: Introduce config for plane zpos property Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 25/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 26/37] drm/vkms: Introduce config for connector type Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 27/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 28/37] drm/vkms: Rename vkms_connector_init to vkms_connector_init_static Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 29/37] drm/vkms: Introduce config for connector supported colorspace Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 30/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 31/37] drm/vkms: Introduce config for connector EDID Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 32/37] drm/vkms: Introduce configfs " Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 33/37] drm/vkms: Store the enabled/disabled status for connector Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 34/37] drm/vkms: Allow to hot-add connectors Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 35/37] drm/vkms: Introduce configfs for dynamic connector creation Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 36/37] drm/vkms: Add connector parent configuration in vkms_config Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 16:48 ` [PATCH v4 37/37] drm/vkms: Add ConfigFS interface for connector parent and port_id Louis Chauvet
2026-04-22 21:30 ` Claude review: " Claude Code Review Bot
2026-04-22 21:30 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260422-vkms-all-config-v4-0-dbb52e9aadc3@bootlin.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox