Claude review: Support sparse mappings in Panthor

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Support sparse mappings in Panthor
Author: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= <adrian.larumbe@collabora.com>
Patches: 7
Reviewed: 2026-04-23T07:41:44.304387

---

This v9 series adds sparse mapping support to the Panthor (Mali CSF) GPU driver, allowing userspace (Vulkan) to bind virtual address ranges over a kernel-allocated dummy BO in a cyclic fashion. The approach of per-file-context dummy BOs for information isolation is sound, and the series is well-structured with clean preparatory patches.

However, there are several issues that need attention:

1. **uAPI enum ordering break** (Patch 1) — inserting `DRM_PANTHOR_DEV_QUERY_MMU_INFO` in the middle of an auto-numbered enum changes the values of all subsequent members, breaking existing userspace.
2. **Memory leak on error path** (Patch 5) — `panthor_vm_pool_create` leaks memory if `panthor_dummy_bo_create` fails.
3. **Wrong address in hugepage alignment check** (Patch 5) — the `op->next` branch of `unmap_hugepage_align` now passes `*unmap_start` instead of the original `unmap_end - 1`, which is incorrect for non-sparse mappings.

---

---
Generated by Claude Code Patch Reviewer