From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Expose GPU page sizes to UM
Date: Thu, 23 Apr 2026 07:41:44 +1000 [thread overview]
Message-ID: <review-patch1-20260422122538.3117380-2-adrian.larumbe@collabora.com> (raw)
In-Reply-To: <20260422122538.3117380-2-adrian.larumbe@collabora.com>
Patch Review
This patch exposes the MMU page size bitmap to userspace via a new `DRM_PANTHOR_DEV_QUERY_MMU_INFO` query type and `struct drm_panthor_mmu_info`.
**uAPI enum value collision (major):** The new enum member is inserted between `DRM_PANTHOR_DEV_QUERY_CSIF_INFO` and `DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO`. Since the enum is auto-numbered (only `GPU_INFO = 0` has an explicit value), this shifts the values of `TIMESTAMP_INFO` (2→3) and `GROUP_PRIORITIES_INFO` (3→4). Any existing userspace compiled with the old header will send the wrong query type for those two.
```c
+ /** @DRM_PANTHOR_DEV_QUERY_MMU_INFO: Query MMU information. */
+ DRM_PANTHOR_DEV_QUERY_MMU_INFO,
+
/** @DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO: Query timestamp information. */
DRM_PANTHOR_DEV_QUERY_TIMESTAMP_INFO,
```
The new member should be appended **after** `DRM_PANTHOR_DEV_QUERY_GROUP_PRIORITIES_INFO` to preserve existing numeric values, or assigned an explicit value.
The rest of the patch is straightforward — `panthor_mmu_info_init()` sets the bitmap, the ioctl copies it out. Reviewed-by tags from Steven Price and Boris Brezillon are present.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 12:25 [PATCH v9 0/6] Support sparse mappings in Panthor Adrián Larumbe
2026-04-22 12:25 ` [PATCH v9 1/6] drm/panthor: Expose GPU page sizes to UM Adrián Larumbe
2026-04-22 21:41 ` Claude Code Review Bot [this message]
2026-04-22 12:25 ` [PATCH v9 2/6] drm/panthor: Pass vm_bind_op to vm_prepare_map_op_ctx Adrián Larumbe
2026-04-22 21:41 ` Claude review: " Claude Code Review Bot
2026-04-22 12:25 ` [PATCH v9 3/6] drm/panthor: Delete spurious whitespace from uAPI header Adrián Larumbe
2026-04-22 21:41 ` Claude review: " Claude Code Review Bot
2026-04-22 12:25 ` [PATCH v9 4/6] drm/panthor: Remove unused operation context field Adrián Larumbe
2026-04-22 21:41 ` Claude review: " Claude Code Review Bot
2026-04-22 12:25 ` [PATCH v9 5/6] drm/panthor: Support sparse mappings Adrián Larumbe
2026-04-22 21:41 ` Claude review: " Claude Code Review Bot
2026-04-22 12:25 ` [PATCH v9 6/6] drm/panthor: Bump the driver version to 1.9 Adrián Larumbe
2026-04-22 21:41 ` Claude review: " Claude Code Review Bot
2026-04-22 21:41 ` Claude review: Support sparse mappings in Panthor Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-29 18:32 [PATCH v10 0/6] " Adrián Larumbe
2026-04-29 18:32 ` [PATCH v10 1/6] drm/panthor: Expose GPU page sizes to UM Adrián Larumbe
2026-05-05 1:14 ` Claude review: " Claude Code Review Bot
2026-03-13 15:09 [PATCH v5 00/11] Support repeated mappings in GPUVM and Panthor Adrián Larumbe
2026-03-13 15:09 ` [PATCH v5 01/11] drm/panthor: Expose GPU page sizes to UM Adrián Larumbe
2026-03-13 20:48 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260422122538.3117380-2-adrian.larumbe@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox