From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: clarify average bandwidth comment in dcn4_calcs
Date: Tue, 28 Apr 2026 15:11:58 +1000 [thread overview]
Message-ID: <review-overall-20260426191825.9727-1-adri.vero.dev@gmail.com> (raw)
In-Reply-To: <20260426191825.9727-1-adri.vero.dev@gmail.com>
Overall Series Review
Subject: drm/amd/display: clarify average bandwidth comment in dcn4_calcs
Author: Adriano Vero <adri.vero.dev@gmail.com>
Patches: 1
Reviewed: 2026-04-28T15:11:58.284280
---
This is a single comment-only patch that replaces a stale `FIXME_DCN4` with a proper block comment explaining the design rationale. There are no functional code changes.
The patch is **correct and well-motivated**. The old comment expressed uncertainty about whether `cursor_bw` and `tdlut` bandwidth should be included. Inspecting the four accumulation sites at lines 2867-2871 confirms that `cursor_bw[k]` is already included in all four (sys_active SDP, sys_active DRAM, svp_prefetch SDP, svp_prefetch DRAM), and `tdlut` bandwidth is absent from all of them. The new comment accurately documents this state and provides the rationale for tdlut's absence (fetched only during prefetch/blanking).
No concerns with this patch.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-28 5:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 19:18 [PATCH] drm/amd/display: clarify average bandwidth comment in dcn4_calcs Adriano Vero
2026-04-28 5:11 ` Claude review: " Claude Code Review Bot
2026-04-28 5:11 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260426191825.9727-1-adri.vero.dev@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox