public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: clarify average bandwidth comment in dcn4_calcs
Date: Tue, 28 Apr 2026 15:11:58 +1000	[thread overview]
Message-ID: <review-patch1-20260426191825.9727-1-adri.vero.dev@gmail.com> (raw)
In-Reply-To: <20260426191825.9727-1-adri.vero.dev@gmail.com>

Patch Review

**Accuracy of the replacement comment**: Verified against the code. The four accumulation sites at lines 2867-2871 all include `+ cursor_bw[k]`, confirming the "cursor_bw is included" claim. No `tdlut` term appears anywhere in this loop body, confirming the "tdlut bandwidth is intentionally excluded" claim. The phantom pipe handling is also correct: the `if (!dml_is_phantom_pipe(...))` guard on lines 2866-2869 excludes phantom pipes from sys_active, while lines 2870-2871 (outside the guard) include all pipes in svp_prefetch.

**Comment style**: The old comment used C++ style (`//`), the new one uses C block comment style (`/* ... */`). The kernel coding style prefers C-style block comments, so this is a minor style improvement as well.

**Minor nit**: The commit message says "cursor_bw is already correctly included in all four accumulation sites *below* the comment" — this is accurate. One could argue the new comment is slightly verbose for what it describes, but given that the original FIXME expressed genuine confusion about a non-obvious design choice, the added detail is justified.

**Verdict**: Looks good. The patch resolves a stale FIXME with an accurate explanation of the existing behavior. No functional changes, no risk.

Reviewed-by: appropriate.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-28  5:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-26 19:18 [PATCH] drm/amd/display: clarify average bandwidth comment in dcn4_calcs Adriano Vero
2026-04-28  5:11 ` Claude Code Review Bot [this message]
2026-04-28  5:11 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260426191825.9727-1-adri.vero.dev@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox