public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe
Date: Tue, 28 Apr 2026 14:52:59 +1000	[thread overview]
Message-ID: <review-overall-20260427075856.85208-1-clamor95@gmail.com> (raw)
In-Reply-To: <20260427075856.85208-1-clamor95@gmail.com>

Overall Series Review

Subject: drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe
Author: Svyatoslav Ryhel <clamor95@gmail.com>
Patches: 3
Reviewed: 2026-04-28T14:52:59.542322

---

This is a single-patch series that moves `pm_runtime_enable()`, `pm_runtime_use_autosuspend()`, and `pm_runtime_set_autosuspend_delay()` from the `gr*d_runtime_resume()` callbacks into `gr*d_probe()` for both gr2d and gr3d Tegra DRM drivers.

The fundamental change is **correct and desirable**. Calling `pm_runtime_enable()` from within a `runtime_resume` callback is wrong for two reasons:
1. It creates a chicken-and-egg problem — runtime PM must be enabled before `runtime_resume` can be invoked through normal paths, so on initial boot (without a prior sleep/resume cycle), runtime PM is never enabled.
2. On each subsequent resume, it calls `pm_runtime_enable()` again, decrementing `disable_depth` below zero, producing a kernel warning about an unbalanced enable.

Moving these calls to `probe()` properly pairs them with the `pm_runtime_disable()` already present in `gr*d_remove()`.

However, there is a **call ordering issue** that should be fixed before merging.

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-28  4:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-27  7:58 [PATCH v1 0/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe Svyatoslav Ryhel
2026-04-27  7:58 ` [PATCH v1 1/1] " Svyatoslav Ryhel
2026-04-28  1:52   ` Mikko Perttunen
2026-04-28  4:52   ` Claude review: " Claude Code Review Bot
2026-04-28  4:52 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-03 16:38 [PATCH v2 0/2] " Svyatoslav Ryhel
2026-05-04 22:41 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260427075856.85208-1-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox