public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe
Date: Tue, 05 May 2026 08:41:52 +1000	[thread overview]
Message-ID: <review-overall-20260503163842.213489-1-clamor95@gmail.com> (raw)
In-Reply-To: <20260503163842.213489-1-clamor95@gmail.com>

Overall Series Review

Subject: drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe
Author: Svyatoslav Ryhel <clamor95@gmail.com>
Patches: 4
Reviewed: 2026-05-05T08:41:52.459997

---

This is a well-motivated 2-patch series fixing power management issues in the Tegra GR2D/GR3D DRM drivers. The series makes two corrections:

1. Reorders address register map initialization before `host1x_client_register()` to close a theoretical race window.
2. Moves `pm_runtime_enable()` and autosuspend configuration from the runtime resume callback to `probe()`, and removes the corresponding PM teardown from `exit()`. This follows the standard Linux PM pattern and fixes a real resume malfunction.

The current upstream code has `pm_runtime_enable()` inside `gr*d_runtime_resume()`, which is architecturally wrong — runtime PM must be enabled before runtime resume can ever be called by the PM core. The only way this ever worked is through the `SET_SYSTEM_SLEEP_PM_OPS` path (`pm_runtime_force_resume`), and it breaks on the second system suspend/resume cycle because `pm_runtime_enable()` gets called with `disable_depth` already at 0, producing an "Unbalanced pm_runtime_enable!" warning and subsequent misbehavior.

Both patches are correct and the series is in a good state. One typo and one minor concern noted below. The Acked-by from Mikko Perttunen on patch 2 is a good sign.

**Series: Looks good with minor nits.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-04 22:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-03 16:38 [PATCH v2 0/2] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe Svyatoslav Ryhel
2026-05-03 16:38 ` [PATCH v2 1/2] drm/tegra: gr2d/gr3d: Initialize address register map before HOST1X client is registered Svyatoslav Ryhel
2026-05-04 22:41   ` Claude review: " Claude Code Review Bot
2026-05-03 16:38 ` [PATCH v2 2/2] drm/tegra: gr2d/gr3d: Contain PM in the gr*d_probe/gr*d_remove Svyatoslav Ryhel
2026-05-03 18:36   ` Svyatoslav Ryhel
2026-05-04 22:41   ` Claude review: " Claude Code Review Bot
2026-05-04 22:41 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-04-27  7:58 [PATCH v1 0/1] drm/tegra: gr2d/gr3d: Move pm_runtime_enable to gr*d_probe Svyatoslav Ryhel
2026-04-27  7:58 ` [PATCH v1 1/1] " Svyatoslav Ryhel
2026-04-28  4:52   ` Claude review: " Claude Code Review Bot
2026-04-28  4:52 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260503163842.213489-1-clamor95@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox