From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display/msm: Fix typo in clock-names property
Date: Tue, 28 Apr 2026 14:29:39 +1000 [thread overview]
Message-ID: <review-overall-20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Overall Series Review
Subject: dt-bindings: display/msm: Fix typo in clock-names property
Author: Prabhakar <prabhakar.csengg@gmail.com>
Patches: 1
Reviewed: 2026-04-28T14:29:39.561063
---
This is a single-patch fix for a straightforward typo in the MSM DisplayPort controller device-tree binding schema. The property name `clocks-names` (with a spurious "s") was used in five `allOf/if/then` conditional blocks instead of the correct `clock-names`. Because YAML schema validators match property names exactly, these misspelled entries were silently **not constraining anything** — the `minItems`/`maxItems` limits on `clock-names` within these conditional blocks were dead code. The fix is correct and complete.
**Verdict: Patch looks good.** Straightforward, low-risk, obviously correct.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-28 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 15:46 [PATCH] dt-bindings: display/msm: Fix typo in clock-names property Prabhakar
2026-04-28 4:29 ` Claude review: " Claude Code Review Bot
2026-04-28 4:29 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox