From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display/msm: Fix typo in clock-names property
Date: Tue, 28 Apr 2026 14:29:39 +1000 [thread overview]
Message-ID: <review-patch1-20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
Patch Review
**Status: Reviewed-by worthy**
The patch changes five occurrences of the misspelled property `clocks-names` to the correct `clock-names` in `Documentation/devicetree/bindings/display/msm/dp-controller.yaml`.
**What was broken:** The `allOf` conditional blocks for various SoCs (sc7180, sc7280, sc8280xp, x1e80100, sc8180x, sdm845, sm8350, sm8650, sa8775p, glymur) contained:
```yaml
- clocks-names:
+ clock-names:
```
Since the top-level `properties` block at line 102 correctly defines `clock-names`, and the `required` list at line 185 correctly references `clock-names`, these misspelled conditional constraints were being silently ignored by the schema validator. DT files could pass validation even if they had the wrong number of clock names for their compatible string.
**Correctness:** After the patch, all references in the file consistently use `clock-names` (confirmed by grep — 8 occurrences, zero `clocks-names` remaining). The change is purely mechanical — no semantic or structural changes.
**One minor note:** The commit message and patch are well-formed. The `Note, patch applies on top of next-20260427` is useful context for the maintainer. No issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-28 4:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 15:46 [PATCH] dt-bindings: display/msm: Fix typo in clock-names property Prabhakar
2026-04-28 4:29 ` Claude review: " Claude Code Review Bot
2026-04-28 4:29 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260427154658.276737-1-prabhakar.mahadev-lad.rj@bp.renesas.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox