* [PATCH] dt-bindings: display/msm: Fix typo in clock-names property
@ 2026-04-27 15:46 Prabhakar
2026-04-28 4:29 ` Claude review: " Claude Code Review Bot
2026-04-28 4:29 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Prabhakar @ 2026-04-27 15:46 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Kuogee Hsieh
Cc: linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
Prabhakar, Lad Prabhakar
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Fix the typo "clocks-names" to "clock-names" in the allOf/if conditional
blocks.
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Note, patch applies on top of next-20260427.
---
.../devicetree/bindings/display/msm/dp-controller.yaml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 8239adb7f7d3..43ebd053f98c 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -243,7 +243,7 @@ allOf:
clocks:
minItems: 5
maxItems: 5
- clocks-names:
+ clock-names:
minItems: 5
maxItems: 5
@@ -264,7 +264,7 @@ allOf:
clocks:
minItems: 5
maxItems: 6
- clocks-names:
+ clock-names:
minItems: 5
maxItems: 6
@@ -286,7 +286,7 @@ allOf:
clocks:
minItems: 6
maxItems: 6
- clocks-names:
+ clock-names:
minItems: 6
maxItems: 6
@@ -306,7 +306,7 @@ allOf:
clocks:
minItems: 6
maxItems: 8
- clocks-names:
+ clock-names:
minItems: 6
maxItems: 8
@@ -326,7 +326,7 @@ allOf:
clocks:
minItems: 5
maxItems: 6
- clocks-names:
+ clock-names:
minItems: 5
maxItems: 6
--
2.54.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Claude review: dt-bindings: display/msm: Fix typo in clock-names property
2026-04-27 15:46 [PATCH] dt-bindings: display/msm: Fix typo in clock-names property Prabhakar
@ 2026-04-28 4:29 ` Claude Code Review Bot
2026-04-28 4:29 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28 4:29 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: dt-bindings: display/msm: Fix typo in clock-names property
Author: Prabhakar <prabhakar.csengg@gmail.com>
Patches: 1
Reviewed: 2026-04-28T14:29:39.561063
---
This is a single-patch fix for a straightforward typo in the MSM DisplayPort controller device-tree binding schema. The property name `clocks-names` (with a spurious "s") was used in five `allOf/if/then` conditional blocks instead of the correct `clock-names`. Because YAML schema validators match property names exactly, these misspelled entries were silently **not constraining anything** — the `minItems`/`maxItems` limits on `clock-names` within these conditional blocks were dead code. The fix is correct and complete.
**Verdict: Patch looks good.** Straightforward, low-risk, obviously correct.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: dt-bindings: display/msm: Fix typo in clock-names property
2026-04-27 15:46 [PATCH] dt-bindings: display/msm: Fix typo in clock-names property Prabhakar
2026-04-28 4:29 ` Claude review: " Claude Code Review Bot
@ 2026-04-28 4:29 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28 4:29 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Status: Reviewed-by worthy**
The patch changes five occurrences of the misspelled property `clocks-names` to the correct `clock-names` in `Documentation/devicetree/bindings/display/msm/dp-controller.yaml`.
**What was broken:** The `allOf` conditional blocks for various SoCs (sc7180, sc7280, sc8280xp, x1e80100, sc8180x, sdm845, sm8350, sm8650, sa8775p, glymur) contained:
```yaml
- clocks-names:
+ clock-names:
```
Since the top-level `properties` block at line 102 correctly defines `clock-names`, and the `required` list at line 185 correctly references `clock-names`, these misspelled conditional constraints were being silently ignored by the schema validator. DT files could pass validation even if they had the wrong number of clock names for their compatible string.
**Correctness:** After the patch, all references in the file consistently use `clock-names` (confirmed by grep — 8 occurrences, zero `clocks-names` remaining). The change is purely mechanical — no semantic or structural changes.
**One minor note:** The commit message and patch are well-formed. The `Note, patch applies on top of next-20260427` is useful context for the maintainer. No issues found.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-28 4:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 15:46 [PATCH] dt-bindings: display/msm: Fix typo in clock-names property Prabhakar
2026-04-28 4:29 ` Claude review: " Claude Code Review Bot
2026-04-28 4:29 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox