* [PATCH] fbdev: defio: Remove duplicate include of linux/module.h
@ 2026-04-28 3:17 Chen Ni
2026-04-28 3:38 ` Claude review: " Claude Code Review Bot
2026-04-28 3:38 ` Claude Code Review Bot
0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2026-04-28 3:17 UTC (permalink / raw)
To: deller, simona; +Cc: linux-fbdev, dri-devel, linux-kernel, Chen Ni
Remove duplicate inclusion of linux/module.h in fb_defio.c to clean up
redundant code.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/video/fbdev/core/fb_defio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c
index a12dd25ab697..fd00b86e1ae6 100644
--- a/drivers/video/fbdev/core/fb_defio.c
+++ b/drivers/video/fbdev/core/fb_defio.c
@@ -14,7 +14,6 @@
#include <linux/export.h>
#include <linux/string.h>
#include <linux/mm.h>
-#include <linux/module.h>
#include <linux/vmalloc.h>
#include <linux/delay.h>
#include <linux/interrupt.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Claude review: fbdev: defio: Remove duplicate include of linux/module.h
2026-04-28 3:17 [PATCH] fbdev: defio: Remove duplicate include of linux/module.h Chen Ni
@ 2026-04-28 3:38 ` Claude Code Review Bot
2026-04-28 3:38 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28 3:38 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: fbdev: defio: Remove duplicate include of linux/module.h
Author: Chen Ni <nichen@iscas.ac.cn>
Patches: 1
Reviewed: 2026-04-28T13:38:42.747849
---
This is a single trivial cleanup patch that removes a duplicate `#include <linux/module.h>` from `drivers/video/fbdev/core/fb_defio.c`. The change is correct and harmless. The file retains its first `#include <linux/module.h>` at line 11, which is needed for `THIS_MODULE`, `try_module_get()`, and `module_put()` used later in the file.
No functional impact. No concerns.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
* Claude review: fbdev: defio: Remove duplicate include of linux/module.h
2026-04-28 3:17 [PATCH] fbdev: defio: Remove duplicate include of linux/module.h Chen Ni
2026-04-28 3:38 ` Claude review: " Claude Code Review Bot
@ 2026-04-28 3:38 ` Claude Code Review Bot
1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28 3:38 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Status: Correct, no issues.**
The file had `#include <linux/module.h>` in two places:
1. Line 11 (retained — first in the include block)
2. Line 17 between `mm.h` and `vmalloc.h` (removed by this patch)
The removed line:
```c
-#include <linux/module.h>
```
The remaining include at line 11 is sufficient — the file uses `THIS_MODULE` (lines 113, 122, 369) and `try_module_get()`/`module_put()`, all of which are provided by `linux/module.h`.
The commit message is accurate and the Signed-off-by is present.
**Reviewed-by: appropriate to give.** This is a straightforward, obviously correct cleanup.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-28 3:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-28 3:17 [PATCH] fbdev: defio: Remove duplicate include of linux/module.h Chen Ni
2026-04-28 3:38 ` Claude review: " Claude Code Review Bot
2026-04-28 3:38 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox