From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: focaltech-ota7290b: Fix error check for devm_drm_panel_alloc()
Date: Tue, 05 May 2026 11:48:20 +1000 [thread overview]
Message-ID: <review-overall-20260429080527.1456732-1-nichen@iscas.ac.cn> (raw)
In-Reply-To: <20260429080527.1456732-1-nichen@iscas.ac.cn>
Overall Series Review
Subject: drm/panel: focaltech-ota7290b: Fix error check for devm_drm_panel_alloc()
Author: Chen Ni <nichen@iscas.ac.cn>
Patches: 2
Reviewed: 2026-05-05T11:48:20.738806
---
This is a single-patch fix for an incorrect error check on `devm_drm_panel_alloc()` in the Focaltech OTA7290B panel driver. The fix is **correct and necessary**.
`devm_drm_panel_alloc()` (defined in `include/drm/drm_panel.h:318`) wraps `__devm_drm_panel_alloc()`, which returns `ERR_PTR(-EINVAL)` when `funcs` is NULL and `ERR_PTR(err)` when `devm_add_action_or_reset()` fails (`drm_panel.c:411,424`). It never returns NULL. The existing `!ctx` / `-ENOMEM` check would silently pass through error pointers, leading to a kernel oops on the subsequent dereference at `mipi_dsi_set_drvdata(dsi, ctx)`.
**Verdict: Patch looks good. Recommend applying.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-05 1:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 8:05 [PATCH] drm/panel: focaltech-ota7290b: Fix error check for devm_drm_panel_alloc() Chen Ni
2026-04-30 9:45 ` neil.armstrong
2026-05-05 1:48 ` Claude review: " Claude Code Review Bot
2026-05-05 1:48 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260429080527.1456732-1-nichen@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox