From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Drop unused drm_device_class_(un)register API
Date: Tue, 05 May 2026 11:46:02 +1000 [thread overview]
Message-ID: <review-overall-20260429085726.69842-1-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20260429085726.69842-1-tvrtko.ursulin@igalia.com>
Overall Series Review
Subject: drm: Drop unused drm_device_class_(un)register API
Author: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Patches: 4
Reviewed: 2026-05-05T11:46:02.517455
---
This is a single, straightforward cleanup patch that removes dead code. The `drm_class_device_register()` and `drm_class_device_unregister()` functions have had no callers since TTM dropped its sysfs directory (commit `ed89fff97382`). The patch correctly removes both the implementations in `drm_sysfs.c` and the declarations plus the now-unneeded `struct device` forward declaration in `drm_sysfs.h`. A grep of the kernel tree confirms there are zero remaining callers.
**Verdict: Looks good.** This is a clean, no-risk removal of unused exported symbols.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-05 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 8:57 [PATCH] drm: Drop unused drm_device_class_(un)register API Tvrtko Ursulin
2026-04-29 9:35 ` Thomas Zimmermann
2026-04-29 10:45 ` Tvrtko Ursulin
2026-04-29 12:15 ` Christian König
2026-05-05 1:46 ` Claude review: " Claude Code Review Bot
2026-05-05 1:46 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260429085726.69842-1-tvrtko.ursulin@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox