From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Drop unused drm_device_class_(un)register API
Date: Tue, 05 May 2026 11:46:02 +1000 [thread overview]
Message-ID: <review-patch1-20260429085726.69842-1-tvrtko.ursulin@igalia.com> (raw)
In-Reply-To: <20260429085726.69842-1-tvrtko.ursulin@igalia.com>
Patch Review
**Correctness: Good.**
- The removal of `drm_class_device_register()` and `drm_class_device_unregister()` from `drm_sysfs.c` is complete — both function bodies and their `EXPORT_SYMBOL_GPL` lines are removed.
- The header `drm_sysfs.h` correctly removes both function declarations and the `struct device` forward declaration, which was only needed for those function prototypes.
- The remaining declarations in `drm_sysfs.h` (`drm_sysfs_hotplug_event`, `drm_sysfs_connector_hotplug_event`, `drm_sysfs_connector_property_event`) use `struct drm_device`, `struct drm_connector`, and `struct drm_property` — none require `struct device`, so removing that forward declaration is safe.
**Nit (commit message):** The subject says `drm_device_class_(un)register` but the actual function names are `drm_class_device_register` / `drm_class_device_unregister` — the word order is swapped. This is a minor cosmetic issue in the subject line:
```
Subject: [PATCH] drm: Drop unused drm_device_class_(un)register API
```
Should be:
```
Subject: [PATCH] drm: Drop unused drm_class_device_(un)register API
```
**No other issues.** The patch is minimal, correct, and safe to merge (with optionally fixing the subject typo).
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-05 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 8:57 [PATCH] drm: Drop unused drm_device_class_(un)register API Tvrtko Ursulin
2026-04-29 9:35 ` Thomas Zimmermann
2026-04-29 10:45 ` Tvrtko Ursulin
2026-04-29 12:15 ` Christian König
2026-05-05 1:46 ` Claude review: " Claude Code Review Bot
2026-05-05 1:46 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260429085726.69842-1-tvrtko.ursulin@igalia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox