* [PATCH] drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel @ 2026-04-29 14:52 Adam Szyma 2026-04-30 9:45 ` Neil Armstrong 2026-05-05 0:23 ` Claude review: " Claude Code Review Bot 0 siblings, 2 replies; 4+ messages in thread From: Adam Szyma @ 2026-04-29 14:52 UTC (permalink / raw) To: dri-devel Cc: linux-kernel, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Adam Szyma Add support for the CSOT MPP36 T9 eDP panel (manufacturer ID: CSW, product ID: 0x143d) used in the Dell Inspiron 14 Plus 5441 laptop. Without this entry the kernel logs: panel-simple-dp-aux: Unknown panel CSW 0x143d, using conservative timings and brightness control is non-functional on affected devices. Tested-by: Adam Szyma <adamszyma@wp.pl> Signed-off-by: Adam Szyma <adamszyma@wp.pl> --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index f3cdaea89..0d0072f29 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -2073,6 +2073,7 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('C', 'S', 'W', 0x1103, &delay_200_500_e80_d50, "MNB601LS1-3"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50_d100, "MNB601LS1-4"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x110a, &delay_200_500_e50, "PNB601LS1-2"), + EDP_PANEL_ENTRY('C', 'S', 'W', 0x143d, &delay_200_500_e50, "MPP36 CSOT T9"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x143f, &delay_200_500_e50, "MNE007QS3-6"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x1448, &delay_200_500_e50, "MNE007QS3-7"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x144b, &delay_200_500_e80, "MNE001BS1-4"), -- 2.53.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel 2026-04-29 14:52 [PATCH] drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel Adam Szyma @ 2026-04-30 9:45 ` Neil Armstrong 2026-04-30 13:56 ` [PATCH v2] " Adam Szyma 2026-05-05 0:23 ` Claude review: " Claude Code Review Bot 1 sibling, 1 reply; 4+ messages in thread From: Neil Armstrong @ 2026-04-30 9:45 UTC (permalink / raw) To: Adam Szyma, dri-devel Cc: linux-kernel, Andrzej Hajda, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec On 4/29/26 16:52, Adam Szyma wrote: > Add support for the CSOT MPP36 T9 eDP panel (manufacturer ID: CSW, > product ID: 0x143d) used in the Dell Inspiron 14 Plus 5441 laptop. > > Without this entry the kernel logs: > panel-simple-dp-aux: Unknown panel CSW 0x143d, using conservative timings > > and brightness control is non-functional on affected devices. > > Tested-by: Adam Szyma <adamszyma@wp.pl> I think it's assumed you tested the patch, so drop this. Neil > Signed-off-by: Adam Szyma <adamszyma@wp.pl> > --- > drivers/gpu/drm/panel/panel-edp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c > index f3cdaea89..0d0072f29 100644 > --- a/drivers/gpu/drm/panel/panel-edp.c > +++ b/drivers/gpu/drm/panel/panel-edp.c > @@ -2073,6 +2073,7 @@ static const struct edp_panel_entry edp_panels[] = { > EDP_PANEL_ENTRY('C', 'S', 'W', 0x1103, &delay_200_500_e80_d50, "MNB601LS1-3"), > EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50_d100, "MNB601LS1-4"), > EDP_PANEL_ENTRY('C', 'S', 'W', 0x110a, &delay_200_500_e50, "PNB601LS1-2"), > + EDP_PANEL_ENTRY('C', 'S', 'W', 0x143d, &delay_200_500_e50, "MPP36 CSOT T9"), > EDP_PANEL_ENTRY('C', 'S', 'W', 0x143f, &delay_200_500_e50, "MNE007QS3-6"), > EDP_PANEL_ENTRY('C', 'S', 'W', 0x1448, &delay_200_500_e50, "MNE007QS3-7"), > EDP_PANEL_ENTRY('C', 'S', 'W', 0x144b, &delay_200_500_e80, "MNE001BS1-4"), ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel 2026-04-30 9:45 ` Neil Armstrong @ 2026-04-30 13:56 ` Adam Szyma 0 siblings, 0 replies; 4+ messages in thread From: Adam Szyma @ 2026-04-30 13:56 UTC (permalink / raw) To: Neil Armstrong, dri-devel Cc: linux-kernel, Andrzej Hajda, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec From: Adam Szyma <adamszyma@wp.pl> To: neil.armstrong@linaro.org, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Andrzej Hajda <andrzej.hajda@intel.com>, Robert Foss <rfoss@kernel.org>, Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com> Subject: [PATCH v2] drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel In-Reply-To: <bc921525-1577-424c-a4f7-a0436f8a0ca1@linaro.org> References: <20260429145251.8445-1-adamszyma@wp.pl> <bc921525-1577-424c-a4f7-a0436f8a0ca1@linaro.org> MIME-Version: 1.0 Content-Type: text/plain Add support for the CSOT MPP36 T9 eDP panel (manufacturer ID: CSW, product ID: 0x143d) used in the Dell Inspiron 14 Plus 5441 laptop. Without this entry the kernel logs: panel-simple-dp-aux: Unknown panel CSW 0x143d, using conservative timings and brightness control is non-functional on affected devices. Signed-off-by: Adam Szyma <adamszyma@wp.pl> --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index f3cdaea89..0d0072f29 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -2073,6 +2073,7 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('C', 'S', 'W', 0x1103, &delay_200_500_e80_d50, "MNB601LS1-3"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50_d100, "MNB601LS1-4"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x110a, &delay_200_500_e50, "PNB601LS1-2"), + EDP_PANEL_ENTRY('C', 'S', 'W', 0x143d, &delay_200_500_e50, "MPP36 CSOT T9"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x143f, &delay_200_500_e50, "MNE007QS3-6"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x1448, &delay_200_500_e50, "MNE007QS3-7"), EDP_PANEL_ENTRY('C', 'S', 'W', 0x144b, &delay_200_500_e80, "MNE001BS1-4"), -- 2.53.0 W dniu 30.04.2026 o 11:45, Neil Armstrong pisze: > On 4/29/26 16:52, Adam Szyma wrote: >> Add support for the CSOT MPP36 T9 eDP panel (manufacturer ID: CSW, >> product ID: 0x143d) used in the Dell Inspiron 14 Plus 5441 laptop. >> >> Without this entry the kernel logs: >> panel-simple-dp-aux: Unknown panel CSW 0x143d, using conservative >> timings >> >> and brightness control is non-functional on affected devices. >> >> Tested-by: Adam Szyma <adamszyma@wp.pl> > > I think it's assumed you tested the patch, so drop this. > > Neil > >> Signed-off-by: Adam Szyma <adamszyma@wp.pl> >> --- >> drivers/gpu/drm/panel/panel-edp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/gpu/drm/panel/panel-edp.c >> b/drivers/gpu/drm/panel/panel-edp.c >> index f3cdaea89..0d0072f29 100644 >> --- a/drivers/gpu/drm/panel/panel-edp.c >> +++ b/drivers/gpu/drm/panel/panel-edp.c >> @@ -2073,6 +2073,7 @@ static const struct edp_panel_entry >> edp_panels[] = { >> EDP_PANEL_ENTRY('C', 'S', 'W', 0x1103, &delay_200_500_e80_d50, >> "MNB601LS1-3"), >> EDP_PANEL_ENTRY('C', 'S', 'W', 0x1104, &delay_200_500_e50_d100, >> "MNB601LS1-4"), >> EDP_PANEL_ENTRY('C', 'S', 'W', 0x110a, &delay_200_500_e50, >> "PNB601LS1-2"), >> + EDP_PANEL_ENTRY('C', 'S', 'W', 0x143d, &delay_200_500_e50, >> "MPP36 CSOT T9"), >> EDP_PANEL_ENTRY('C', 'S', 'W', 0x143f, &delay_200_500_e50, >> "MNE007QS3-6"), >> EDP_PANEL_ENTRY('C', 'S', 'W', 0x1448, &delay_200_500_e50, >> "MNE007QS3-7"), >> EDP_PANEL_ENTRY('C', 'S', 'W', 0x144b, &delay_200_500_e80, >> "MNE001BS1-4"), > ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Claude review: drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel 2026-04-29 14:52 [PATCH] drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel Adam Szyma 2026-04-30 9:45 ` Neil Armstrong @ 2026-05-05 0:23 ` Claude Code Review Bot 1 sibling, 0 replies; 4+ messages in thread From: Claude Code Review Bot @ 2026-05-05 0:23 UTC (permalink / raw) To: dri-devel-reviews Overall Series Review Subject: drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel Author: Adam Szyma <adamszyma@wp.pl> Patches: 3 Reviewed: 2026-05-05T10:23:35.326581 --- This mbox contains two versions (v1 and v2) of the same single patch: a one-line addition to register the CSOT MPP36 T9 eDP panel (CSW 0x143d) in the `panel-edp` driver. The change is straightforward and follows the established pattern. The v1 patch looks correct, but **v2 has a critical formatting problem** that makes it unapplyable. The v2 was sent as an inline reply via Mozilla Thunderbird rather than via `git-send-email`, causing the diff to be line-wrapped and whitespace-mangled. The maintainer should either apply v1 (which was sent correctly via git-send-email) or request a properly formatted v2. --- --- Generated by Claude Code Patch Reviewer ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-05 0:23 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-04-29 14:52 [PATCH] drm/panel/panel-edp: Add CSOT MPP36 T9 eDP panel Adam Szyma 2026-04-30 9:45 ` Neil Armstrong 2026-04-30 13:56 ` [PATCH v2] " Adam Szyma 2026-05-05 0:23 ` Claude review: " Claude Code Review Bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox